Add private-deep-imports lint (disallow metro*/src/...)#1528
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: #1528 Differential Revision: D77832800
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
8b974ff to
a4d82c4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Differential Revision: D77832800
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
a4d82c4 to
addaa83
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Differential Revision: D77832800
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
addaa83 to
c11cbf6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Reviewed By: vzaidman Differential Revision: D77832800
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
c11cbf6 to
df8eb12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
df8eb12 to
8c6c045
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Reviewed By: vzaidman Differential Revision: D77832800
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
8c6c045 to
928cbf4
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Reviewed By: vzaidman Differential Revision: D77832800
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
facebook-github-bot
force-pushed
the
export-D77832800
branch
from
928cbf4 to
911cf94
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Reviewed By: vzaidman Differential Revision: D77832800
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
robhogan
added a commit
that referenced
this pull request
Jul 9, 2025
Summary: Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Reviewed By: vzaidman Differential Revision: D77832800
robhogan
force-pushed
the
export-D77832800
branch
from
911cf94 to
319df7b
Compare
Summary: Pull Request resolved: #1528 Lint against `metro*/src/`-style deep imports, as a step towards disallowing them. Deep imports will still be allowed, but will be required to use `metro*/private` and hence explicitly come without semver stability guarantees. Changelog: Internal Reviewed By: vzaidman Differential Revision: D77832800
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77832800 |
robhogan
force-pushed
the
export-D77832800
branch
from
319df7b to
e665d75
Compare
Contributor
|
This pull request has been merged in 2d926dd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D77832800